Make Stream API defined by subscribe() method#809
Merged
Conversation
cowboyd
force-pushed
the
hypothetical-stream-api
branch
from
9c687ee to
803c8d3
Compare
cowboyd
force-pushed
the
hypothetical-stream-api
branch
2 times, most recently
from
6a614ec to
6442053
Compare
cowboyd
changed the title
Stream look like with a subscribe() methodStream API defined by subscribe() method
neurosnap
approved these changes
Nov 1, 2023
cowboyd
force-pushed
the
hypothetical-stream-api
branch
from
6442053 to
4005730
Compare
taras
pushed a commit
that referenced
this pull request
Aug 24, 2025
Make `Stream` API defined by subscribe() method
taras
pushed a commit
that referenced
this pull request
Nov 12, 2025
Make `Stream` API defined by subscribe() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See discussion
Approach
[Symbol.iterator]with asubscribe()subscribe, there is no need to have separateinputandoutputfields. This fixes Settle on API forcreateSignal()/createQueue()andcreateChannel()#796Portinterface which was not carrying its weightopfunction aliftand use it to lift signal functions into operations for channel.