If an uncaught error happens in Scope.run(), crash the scope.#838
Merged
Conversation
neurosnap
approved these changes
Nov 30, 2023
Right now, you can drop errors on the floor if you call `scope.run()` and the operation fails. The error will just dissappear, which goes against the foundations of structured concurrency. Instead, we want to force folks to deal with the error one way or the other if they don't want it to crash their stack. This makes `scope.run()` behave more like `spawn()` where if the error is not caught it crashes its parent. Because scopes can now crash and become totally invalid, calling `Scope.run()` when the scope is inactive is now an error.
cowboyd
force-pushed
the
scope-run-link
branch
from
6c79287 to
45b181f
Compare
taras
pushed a commit
that referenced
this pull request
Nov 12, 2025
If an uncaught error happens in Scope.run(), crash the scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Instead, we want to force folks to deal with the error one way or the other if they don't want it to crash their stack.
Approach
This makes
scope.run()behave more likespawn()where if the error is not caught it crashes its parent.Because scopes can now crash and become totally invalid, calling
Scope.run()when the scope is inactive is now an error.