Conversation
Tasks are supposed to be both operations _and_ promises. However, I had forgotten to make the task consumaeble as an operation, and only a promise. However, because we were monkey-patching `Promise.prototype`, it was actually hiding the gap because everywher we needed to consume a task as an operation, it just used the promise as operation route. I added back the operation functionality, but at the same time, I actually removed the monkey-patch of `Promise.prototype` for our test suite so that we are forced to follow the operation pathway explicitly. That way, we won't risk regressing back to non-functioning operation tasks. It does make the tests a little more verbose, but the added safety is worth it.
cowboyd
force-pushed
the
v4-task-as-operation
branch
from
aa9a9e1 to
512fcd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tasks are supposed to be both operations and promises. However, I had forgotten to make the task consumaeble as an operation, and only a promise. However, because we were monkey-patching
Promise.prototype, it was actually hiding the gap because everywher we needed to consume a task as an operation, it just used the promise as operation route.Approach
I added back the operation functionality, but at the same time, I actually removed the monkey-patch of
Promise.prototypefor our test suite so that we are forced to follow the operation pathway explicitly. That way, we won't risk regressing back to non-functioning operation tasks. It does make the tests a little more verbose, but the added safety is worth it.