Merged
Conversation
* Generating jsr.json and publishing from GA * Appending to deno.json instead * Don't need jsr.json anymore * Added missing explicit types and replaced jsr dependencies * Upgraded deno/dnt * Fix fomatting
cowboyd
approved these changes
Dec 22, 2024
Member
cowboyd
left a comment
cowboyd
left a comment
There was a problem hiding this comment.
Nice! I do wonder why isn't that our linting rules can't catch all of the extra constraints required by JSR. Is there a setting we can apply?
Member
Author
|
These are JSR-specific rules mostly to avoid slow types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I'm going to start migrating dependent projects to effection@4.0.0-alpha.3, so I'd like to have v4 available on JSr.
Approach
Cherry-picked commits from v3