Skip to content

🐛 resolve operation overload before simple function overload#973

Merged
taras merged 1 commit intov4from
fix-call-types
Feb 14, 2025
Merged

🐛 resolve operation overload before simple function overload#973
taras merged 1 commit intov4from
fix-call-types

Conversation

@cowboyd
Copy link
Copy Markdown
Member

@cowboyd cowboyd commented Feb 10, 2025

Motivation

fix #972

@cowboyd cowboyd requested review from jbolda and taras February 10, 2025 22:37
Copy link
Copy Markdown
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only a problem in V4?

@cowboyd
Copy link
Copy Markdown
Member Author

cowboyd commented Feb 10, 2025

@taras good question. I don't think so, although e3 prioritizes Operation functions over async functions 🤷🏻

https://github.com/thefrontside/effection/blob/v3/lib/call.ts#L95-L102

@taras taras merged commit a511636 into v4 Feb 14, 2025
@taras taras deleted the fix-call-types branch February 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants