-
Notifications
You must be signed in to change notification settings - Fork 2
policy(strict): require description in package.json #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a new strict Package.json Metadata policy and documentation, updates AGENTS.md to reference the policy, and adds concise top-level Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@effectionx/bdd
@effectionx/chain
@effectionx/context-api
@effectionx/converge
@effectionx/effect-ts
@effectionx/fs
@effectionx/fx
@effectionx/jsonl-store
@effectionx/node
@effectionx/process
@effectionx/raf
@effectionx/scope-eval
@effectionx/signals
@effectionx/stream-helpers
@effectionx/stream-yaml
@effectionx/task-buffer
@effectionx/test-adapter
@effectionx/timebox
@effectionx/tinyexec
@effectionx/vitest
@effectionx/watch
@effectionx/websocket
@effectionx/worker
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.policies/package-json-metadata.md:
- Around line 20-22: Update the policy text instances that read "No markdown
formatting" to capitalize the proper noun "Markdown" (i.e., change to "No
Markdown formatting"); locate and edit every occurrence of the phrase (including
the duplicate occurrence currently noted elsewhere) so the wording uses
"Markdown" consistently and maintain the existing punctuation, line length, and
other policy constraints.
🧹 Nitpick comments (1)
AGENTS.md (1)
90-94: Align wording with the strict policy to avoid ambiguity.
Line 93 currently omits “single sentence” and “no trailing period,” which are part of the strict policy. Consider aligning the phrasing to prevent inconsistent agent guidance.Proposed wording tweak
- - `description`: Required — concise, under 120 chars, no markdown (see [Package.json Metadata policy](.policies/package-json-metadata.md)) + - `description`: Required — single sentence, under 120 chars, no markdown, no trailing period (see [Package.json Metadata policy](.policies/package-json-metadata.md))
af7c732 to
be9365d
Compare
Add Package.json Metadata policy requiring all published packages to include a description field for npm search and AI agent discovery. - Create .policies/package-json-metadata.md with guidelines - Register policy as Strict in .policies/index.md - Update AGENTS.md package.json Requirements section - Add description field to all 23 published packages - Patch bump all packages to publish updated metadata
be9365d to
1c4c995
Compare
- Capitalize 'Markdown' as proper noun in policy document - Align AGENTS.md description requirement with full policy wording
Update the package abstraction to read description from package.json and prefer it over README-inferred descriptions. This enables the llms.txt route to use concise, agent-friendly descriptions from npm packages. Changes: - Add description field to PackageJsonSchema (node.ts) - Add description field to PackageManifest interface (types.ts) - Update getDescription() in both node.ts and deno.ts to prefer manifest description, falling back to README when not present Works with thefrontside/effectionx#151 which adds description fields to all @effectionx/* packages.
Motivation
AI agents have almost zero knowledge of
@effectionx/*packages. When tested, agents couldn't recommend packages like@effectionx/processfor process spawning or@effectionx/websocketfor WebSocket connections.Package descriptions in
package.jsonare the primary source of truth for npm search and are being used by AI agent discovery systems like llms.txt.Approach
Add strict policy (
.policies/package-json-metadata.md) requiring all published packages to include adescriptionfield:Register policy in
.policies/index.mdas Strict (violations must be fixed before merge)Update AGENTS.md to include
descriptionin package.json requirementsAdd descriptions to all 23 published packages with concise, action-oriented descriptions:
@effectionx/process→ "Spawn and manage child processes with structured concurrency"@effectionx/websocket→ "WebSocket client with stream-based message handling and automatic cleanup"The
.internalpackage is private and does not require a description per the policy.Summary by CodeRabbit
Documentation
Chores