Fix og:image URL rewriting in proxy route#475
Merged
cowboyd merged 1 commit intoproductionfrom Apr 7, 2026
Merged
Conversation
Replace target.origin instead of target.href when rewriting meta content attributes so that the full resource path is preserved. Previously, blog post og:image URLs like /blog/<post>/image.png were collapsed to /effection/image.png, causing 404s during staticalization.
✅ Deploy Preview for frontside canceled.
|
jbolda
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Blog post og:image URLs were being mangled during proxy rewriting, causing
staticalization to crash with 404 errors. For example, an upstream og:image at
https://effection.deno.dev/blog/<post>/meta-effection.png?w=2400&h=1260wasbeing rewritten to
http://localhost:8005/effection/meta-effection.png?w=2400&h=1260,losing the
blog/<post>/path segment entirely.Approach
Replace
target.origininstead oftarget.hrefwhen rewriting meta contentattributes in the proxy route. Using
target.hrefreplaced the full page URL(including path) with the base prefix, which collapsed intermediate path
segments. Using
target.originreplaces only the scheme+host+port, preservingthe full resource path.