Conversation
In order to properly have the `pls --version` command work properly, we need to actually track internally what the version is. This adds a `version.json` file which contains the actual version so that it can be used by the interpreter. JSON was chosen as the format so that in the event that we want to add tooling to the repository that is not in JavaScript, it will be easy to read. The signoff script that generates the "next release" pull request has been modified to update the version file.
5 tasks
taras
approved these changes
Feb 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In order to properly have the
pls --versioncommand work properly, we need to actually track internally what the version is.Approach
This adds a
version.jsonfile which contains the actual version so that it can be used by the interpreter. JSON was chosen as the format so that in the event that we want to add tooling to the repository that is not in JavaScript, it will be easy to read.The signoff script that generates the "next release" pull request has been modified to update the version file.