You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was thinking of adding a --compact flag to the add and remove subcommands as well, which seems convenient to me, but I'm not sure...
Especially add already have plenty of arguments. And if the user tries to --compact with archives that don't have internal listfiles, the command would fail (unless we allowed providing listfiles in those subcommands as well - but that adds further complexity and cognitive load on the user when trying to understand how to use the tool). I'm leaning towards letting the user manually run mpqcli compact afterwards instead of providing convenience flags to add and remove. What do you think?
The reason will be displayed to describe this comment to others. Learn more.
Nice addition - looks good to merge as is. I will delete the 0.9.10 release I made yesterday and make it into a new 0.10.0 release, as there were so many changes that it deserves a minor version bump, not just patch. Will include this PR in the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many operations, like remove, can leave gaps in the archives. This PR adds the
compactsubcommand to rebuild the archive which shrinks its size.