Expose requested environment on Remote#978
Merged
jason0x43 merged 1 commit intotheintern:masterfrom Mar 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
- Coverage 56.75% 56.74% -0.02%
==========================================
Files 60 60
Lines 4678 4679 +1
Branches 1009 1009
==========================================
Hits 2655 2655
- Misses 2023 2024 +1
Continue to review full report at Codecov.
|
Member
|
There's still a chance that the OS or browser version you end up with might not be exactly what you asked for, but I can still see this being a useful indicator. |
Contributor
Author
|
That's great. Thanks for merging. When can we expect the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different drivers are inconsistent in how they report the browser and platform name and version, and IE for example doesn't report the OS version at all. This makes it hard to check the current platform from within tests. This PR adds a
requestedEnvironmentproperty to theremoteobject so that you can see the environment that you requested.