Skip to content

Expose requested environment on Remote#978

Merged
jason0x43 merged 1 commit intotheintern:masterfrom
ascorbic:requested-capabilities
Mar 12, 2019
Merged

Expose requested environment on Remote#978
jason0x43 merged 1 commit intotheintern:masterfrom
ascorbic:requested-capabilities

Conversation

@ascorbic
Copy link
Contributor

Different drivers are inconsistent in how they report the browser and platform name and version, and IE for example doesn't report the OS version at all. This makes it hard to check the current platform from within tests. This PR adds a requestedEnvironment property to the remote object so that you can see the environment that you requested.

@jsf-clabot
Copy link

jsf-clabot commented Mar 12, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #978 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
- Coverage   56.75%   56.74%   -0.02%     
==========================================
  Files          60       60              
  Lines        4678     4679       +1     
  Branches     1009     1009              
==========================================
  Hits         2655     2655              
- Misses       2023     2024       +1
Impacted Files Coverage Δ
src/lib/executors/Node.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bbebd...8e002e5. Read the comment docs.

@jason0x43
Copy link
Member

There's still a chance that the OS or browser version you end up with might not be exactly what you asked for, but I can still see this being a useful indicator.

@jason0x43 jason0x43 merged commit f287235 into theintern:master Mar 12, 2019
@ascorbic
Copy link
Contributor Author

That's great. Thanks for merging. When can we expect the next release?

@ascorbic ascorbic deleted the requested-capabilities branch March 12, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants