_claude_cli: surface stdout when claude -p fails with empty stderr#17
Merged
Merged
Conversation
`claude -p` writes its response (and often its errors) to stdout, not stderr. The wrapper was raising ClaudeCLIError with just stderr[:500], which left "claude exited with code 1: " (empty) on every CI failure mode we've seen — the diagnostic info was being captured and silently discarded. Prefer stderr when present, fall back to stdout, and use "(no output)" when both are empty. Caps the diagnostic at 1KB. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`claude -p` writes both its response and its error diagnostics to stdout in `--print` mode. The wrapper was raising `ClaudeCLIError` with just `stderr[:500]`, which produces "claude exited with code 1: " (empty diag) on every failure mode we've seen in CI.
This patch prefers stderr when present, falls back to stdout, and uses "(no output)" when both are empty.
Why
The soundcheck-action self-test has been failing silently on every run with `ERROR: claude exited with code 1:` and an empty trailing message. With this patch the next run will surface whatever `claude -p` is actually printing, which will tell us if it's an auth issue, a model-routing issue, a flag mismatch, or something else.
Test plan
🤖 Generated with Claude Code