Skip to content

Bugfixes#4

Closed
Bernator wants to merge 2 commits into
thelsing:masterfrom
Bernator:master
Closed

Bugfixes#4
Bernator wants to merge 2 commits into
thelsing:masterfrom
Bernator:master

Conversation

@Bernator

@Bernator Bernator commented Nov 4, 2018

Copy link
Copy Markdown
Contributor

Bugfix, find asap in association Table not working correctly
Bugfix, WriteRequest of last Object in Object Table was not processed

Bugfix, find asap in association Table not working correctly
Bugfix, WriteRequest of last Object in Object Table was not processed
@thelsing

thelsing commented Nov 5, 2018

Copy link
Copy Markdown
Owner

The fix in bau_systemB.cpp is fine. But in the association table the highbyte is the tsap and lowbyte the asap (see 3/5/1 p. 157)
ntohs must be removed because the []-operator does it already. Can you change this please?

@thelsing

thelsing commented Nov 5, 2018

Copy link
Copy Markdown
Owner

I just changed the files manually.

@thelsing thelsing closed this Nov 5, 2018
@Bernator

Bernator commented Nov 6, 2018

Copy link
Copy Markdown
Contributor Author

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants