-
Notifications
You must be signed in to change notification settings - Fork 49
fix(form_field): add color input on helper and label #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdded a public Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-01-07T20:25:20.823ZApplied to files:
📚 Learning: 2025-08-17T20:04:24.034ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
libs/flowbite-angular/form/src/helper/helper.directive.ts(2 hunks)libs/flowbite-angular/form/src/label/label.directive.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-01-07T20:25:20.823Z
Learnt from: MGREMY
Repo: themesberg/flowbite-angular PR: 108
File: libs/flowbite-angular/badge/badge.theme.ts:19-22
Timestamp: 2025-01-07T20:25:20.823Z
Learning: In Flowbite Angular, interfaces like `BadgeColors` that extend color types (e.g., `FlowbiteStandardColors`) intentionally include an index signature `[key: string]` to allow users to define their own custom color keys in the configuration.
Applied to files:
libs/flowbite-angular/form/src/label/label.directive.tslibs/flowbite-angular/form/src/helper/helper.directive.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build code 🛠 (20)
🔇 Additional comments (4)
libs/flowbite-angular/form/src/helper/helper.directive.ts (2)
49-49: LGTM! Theme merging correctly uses the state color.The change from
this.formFieldState().color()tothis.state.color()is correct, as the state now reflects thecolorinput property which can be overridden by users.
31-34: Add tests for the new color input.The new
colorinput should be tested to ensure:
- Default behavior: the color defaults to the form field state color
- Override behavior: users can provide a custom color value
- Theme application: the color is correctly applied in the computed theme
libs/flowbite-angular/form/src/label/label.directive.ts (2)
49-49: LGTM! Theme merging correctly uses the state color.The change from
this.formFieldState().color()tothis.state.color()is correct, as the state now reflects thecolorinput property which can be overridden by users.
31-34: Add tests for the new color input.The new
colorinput should be tested to ensure:
- Default behavior: the color defaults to the form field state color
- Override behavior: users can provide a custom color value
- Theme application: the color is correctly applied in the computed theme
bec6814 to
5aecf67
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number
Issue Number: #146
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Refactor
Style
✏️ Tip: You can customize this high-level summary in your review settings.