Skip to content

docs: change mr-2 to mr-3 on one of the loader buttons for consistency#379

Merged
zoltanszogyenyi merged 3 commits intothemesberg:mainfrom
joaopalmeiro:update-margin-button-loader
Feb 15, 2023
Merged

docs: change mr-2 to mr-3 on one of the loader buttons for consistency#379
zoltanszogyenyi merged 3 commits intothemesberg:mainfrom
joaopalmeiro:update-margin-button-loader

Conversation

@joaopalmeiro
Copy link
Contributor

Hi! 👋

I noticed that one of the example loader buttons has a larger margin than the rest of the icon button examples. For consistency purposes, this PR serves to change the margin from mr-3 to mr-2, if deemed relevant. Let me know your feedback!

Thanks! 😄

@joaopalmeiro
Copy link
Contributor Author

I was checking the packages for React and Svelte and I noticed that mr-3 is used instead of mr-2 for loader buttons. Therefore, this PR could be for updating mr-2 to mr-3 and not the other way around. Let me know your feedback, please.

@joaopalmeiro
Copy link
Contributor Author

@ayushete02 , what value should I keep? mr-2 or mr-3 for all loader buttons to be consistent with what's in the React and Svelte packages?

@ayushete02
Copy link

@joaopalmeiro solve conflicts

@joaopalmeiro joaopalmeiro changed the title docs: change mr-3 to mr-2 on one of the loader buttons for consistency docs: change mr-2 to mr-3 on one of the loader buttons for consistency Feb 7, 2023
@joaopalmeiro
Copy link
Contributor Author

joaopalmeiro commented Feb 7, 2023

@ayushete02, conflicts solved. I've also changed mr-2 to mr-3 on the loader buttons for consistency between Flowbite and the React and Svelte packages.

Copy link

@ayushete02 ayushete02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

Copy link

@ayushete02 ayushete02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve Changes and merging

@ayushete02
Copy link

@zoltanszogyenyi review please

@zoltanszogyenyi zoltanszogyenyi merged commit 4457813 into themesberg:main Feb 15, 2023
@zoltanszogyenyi
Copy link
Member

Hey @joaopalmeiro and @ayushete02,

Thanks for the PR and contribution - merged into main and it will be deployed in the coming days.

Cheers,
Zoltan

@joaopalmeiro joaopalmeiro deleted the update-margin-button-loader branch February 15, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants