UI styles, DateFilter option, Table & templates fixes#2675
Merged
UI styles, DateFilter option, Table & templates fixes#2675
Conversation
Several UI and component fixes: - SCSS: Cleaned up table and upcoming-lesson-card styles (removed/reset borders, added background colors, fixed nesting/indentation, whitespace, and responsive rules). Adjusted profile card/title/statistic margins and removed some redundant responsive hiding. - DateFilter: Added $hide_initial_label property and hide_initial_label(bool) setter. When enabled, the default "All Time" label returns an empty string. - Table: Guard against missing heading class by defaulting to an empty string when rendering <th>. - Templates: Added spacing utility classes to profile wrapper; removed an unused size/style call in security template input; wrapped Withdraw empty-state title with translation function. These changes improve visual consistency, responsiveness, and robustness of component rendering.
shewa12
reviewed
May 8, 2026
shewa12
reviewed
May 8, 2026
shewa12
requested changes
May 8, 2026
Collaborator
shewa12
left a comment
shewa12
left a comment
There was a problem hiding this comment.
Please check the comments
Introduce non-!important display utilities (.tutor-*) and matching breakpoint variants in assets/core/scss/utilities/_layout.scss. Update templates to use the stronger force utilities (tutor-force-*) instead of tutor-hidden/tutor-sm-hidden/tutor-sm-flex to ensure responsive visibility overrides, and adjust a quiz button display to use !important. Also make the announcements create button icon-only. Affected files: _layout.scss, _quiz.scss, and multiple dashboard/learning-area templates.
Remove the boolean parameter from DateFilter::hide_initial_label() and make it always set the internal flag to true, simplifying the method. Replace an isset() ternary with the null coalescing operator in Table when rendering heading classes for cleaner, more concise code. Note: removing the method parameter is a backward-incompatible change for callers that previously passed an argument.
b-l-i-n-d
approved these changes
May 8, 2026
| table { | ||
| min-width: 600px; | ||
| width: 100%; | ||
| border: none; |
Collaborator
There was a problem hiding this comment.
Please do check the other tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several UI and component fixes:
These changes improve visual consistency, responsiveness, and robustness of component rendering.