Add support for uploading files to nested directories #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced an optional 'dir' query parameter to specify nested upload paths. Updated the sample frontend to demonstrate usage with a nested 'test' directory.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for uploading files to nested directories by introducing an optional "dir" query parameter for file uploads and updating the routing configuration accordingly.
- Added a nested directory upload form in the sample frontend.
- Modified Program.cs and RouterExtensions.cs to accept an allowSubDirectories flag.
- Updated the UploadHandler to enforce the subdirectory restriction and construct the correct file key.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Upload.Web.Sample/wwwroot/index.html | Added a form for nested directory uploads using the "dir" query parameter. |
| src/Upload.Web.Sample/Program.cs | Updated route mappings to include an allowSubDirectories flag for different endpoints. |
| src/Upload.Core/Web/UploadHandler.cs | Enhanced file upload logic to handle a "dir" parameter and enforce directory restrictions. |
| src/Upload.Core/Web/RouterExtensions.cs | Modified endpoint mapping extension to pass the allowSubDirectories parameter to the handler. |
| var fullKey = uploadPath is null | ||
| ? key : Path.Combine(uploadPath, key); | ||
|
|
||
| KeyUtils.MushBeSafeKey(fullKey); |
There was a problem hiding this comment.
It appears that there may be a typo in the function name 'MushBeSafeKey'. It is likely intended to be 'MustBeSafeKey'.
Suggested change
| KeyUtils.MushBeSafeKey(fullKey); | |
| KeyUtils.MustBeSafeKey(fullKey); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an optional 'dir' query parameter to specify nested upload paths. Updated the sample frontend to demonstrate usage with a nested 'test' directory.