Skip to content

Conversation

@ahmedash95
Copy link
Contributor

some improvements as mentioned in #19 . i made some additional on langman:show command , this PR will allow users to specify the languages that they want to display like

php artisan langman:show auth --lang=en

for multiple specifications

php artisan langman:show auth --lang=en,ar

@themsaid
Copy link
Owner

themsaid commented Apr 9, 2016

@ahmedash95 how about :

php artisan langman:show auth->en
php artisan langman:show auth->en,ar
php artisan langman:show auth.username->en

To match the syntax of the other commands?

@ahmedash95
Copy link
Contributor Author

@themsaid then i think we will move the specification from the ShowCommand to Manager ?

@ahmedash95
Copy link
Contributor Author

@themsaid i don't know why this chaining confusing me , why don't we just use option lang with any command ?

@rjsworking
Copy link

+1 for php artisan langman:show auth --lang=en,ar

In my opinion this syntax is more suitable for a command.

@themsaid themsaid merged commit e170475 into themsaid:master Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants