build: sync platform icons in bash Meson wrapper for non-Windows CI#41
Merged
themuffinator merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
24158948319).Description
sync_icons_scriptpointing totools/build/sync_icons.pyintools/build/meson_setup.sh.setup,compile, andinstallcommands unlessOPENQ4_SKIP_ICON_SYNC=1, and fail with a clear error if the script is missing.tools/build/meson_setup.ps1to remove a platform discrepancy that caused staged payload validation to fail.Testing
bash -n tools/build/meson_setup.sh, which succeeded.python3 tools/build/sync_icons.py --source-root ., which completed successfully and reported generated/processed icons.bash tools/build/meson_setup.sh setup --wipe builddir ..., which could not complete becausemesonis not installed in this environment and package installation is blocked by the network/proxy, so the Meson build step could not be validated here.Codex Task