chore(repo): ignore local act/secret/metrics artifacts (closes #59)#59
chore(repo): ignore local act/secret/metrics artifacts (closes #59)#59
Conversation
WalkthroughAdded a "Local tooling" block and new ignore patterns to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Coderabit.ai is wrong, the changes to .gitignore are meaningful. However adding ".github/metrics/" was a mistake as this will be used as a sub-repo for metrics. |
This /metrics/ folder is to be used as a sub-repository for metrics generation, and so it should not be ignored.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
50-53: Tighten patterns for secrets and Act payloads; add common Act artifacts
- Anchor secrets to repo root and cover both file and dir.
- Collapse event payload files into a single wildcard.
- Add
.actrcand.act/which Act often creates locally.# Local tooling -.secrets -.act-event.json -.act-issue-event.json +/.secrets +/.secrets/ +/.act-*.json +/.actrc +/.act/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitignore(1 hunks)
🔇 Additional comments (2)
.gitignore (2)
48-49: Section separation LGTMKeeping the local-tooling block distinct from specific-file ignores is clear and readable.
50-53: Resolved —.github/metrics/is not ignored
Searched all .gitignore files, .git/info/exclude (absent), and global excludes (none set); no matches for "metrics" found.
Tighten patterns for secrets and Act payloads; add common Act artifacts
- Anchor secrets to repo root and cover both file and dir.
- Collapse event payload files into a single wildcard.
- Add .actrc and .act/ which Act often creates locally.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
50-56: Deduplicate patterns and fix anchoring inconsistency.
- Line 56 duplicates Line 53’s glob and is unanchored; remove it.
- Lines 51–52 duplicate each other unless you also intend to ignore a file named ".secrets". Prefer one.
Apply:
# Local tooling -/.secrets -/.secrets/ +/.secrets/ /.act-*.json /.actrc /.act/ -.act-issue-event.jsonIf you do want to ignore both a file and a directory named ".secrets", keep both current entries intentionally and drop only the last line.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitignore(1 hunks)
🔇 Additional comments (2)
.gitignore (2)
48-49: LGTM on anchoring /all_code.txt to repo root.
Root-anchored ignore is appropriate and the section separation is clean.
50-56: Confirm removal of .github/metrics ignore.
PR text mentions adding ".github/metrics/"; author comment says that was a mistake because it will be a sub-repo. It’s not present now—please confirm no ignore remains for that path in other templates or global gitignore.
thenarfer
changed the title
thenarfer
changed the title
Merge activity
|
1 participant
name: "Tech Debt / Chore PR"
about: "Refactor, cleanups, dep bumps, infra chores"
chore(gitignore): add local development tooling patterns
Why now
Risk reduction / maintainability / dev-ergonomics.
Scope
Update
.gitignoreto exclude local development tooling files from git tracking.Change
.secretsto ignore sensitive local configuration.act-event.jsonand.act-issue-event.jsonto ignore GitHub Actions local testing files.github/metrics/directory to ignore local metrics dataValidation
Evidence (before/after, logs, links)
N/A - simple gitignore update
—
See
docs/DoR.md&docs/DoD.md.Closes #59
Summary by CodeRabbit