Early abort when events were fetched without limit#81
Closed
johanneslumpe wants to merge 1 commit intothenativeweb:masterfrom
johanneslumpe:patch-1
Closed
Early abort when events were fetched without limit#81johanneslumpe wants to merge 1 commit intothenativeweb:masterfrom johanneslumpe:patch-1
johanneslumpe wants to merge 1 commit intothenativeweb:masterfrom
johanneslumpe:patch-1
Conversation
When using MongoDB as backend and calling `es.getEvents((err, events) => { ... })`, any call to `events.next` will result in an error, as the current logic adds the default `-1` limit to the `skip` value of `0`, resulting in an invalid negative skip value. Invoking the callback in this case with an empty array should be a graceful fix.
adrai
added a commit
that referenced
this pull request
Sep 12, 2016
Contributor
|
thanks for the advice... solved it with v1.8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using MongoDB as backend and calling
es.getEvents((err, events) => { ... }), any call toevents.nextwill result in an error, as the current logic adds the default-1limit to theskipvalue of0, resulting in an invalid negative skip value. Invoking the callback in this case with an empty array should be a graceful fix.