Skip to content

Conversation

@benjaminchristie
Copy link
Contributor

Before, when no text was selected, github was still searched when calling search and open. This commit instead performs a no-op when paired with this keymap:

local search_github = function ()
local csgithub = require("csgithub")
local url = csgithub.search({
includeFilename=false,
includeExtension=true,
})
if url == nil then
return
end
csgithub.open(url)
end

@thenbe
Copy link
Owner

thenbe commented Apr 20, 2023

I think this was opened by mistake, and the changes were already included in #2?

@benjaminchristie
Copy link
Contributor Author

benjaminchristie commented Apr 20, 2023

Closing, I thought I kept the two changes separate. May want to update README.md to account for nil return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants