This repository was archived by the owner on May 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Support for displaying URIs as link in the results table #1
Open
mjovanovik
wants to merge
12
commits into
theodi:master
Choose a base branch
from
mjovanovik:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for displaying values which represent an URI as links (anchors) in the HTML table.
Collaborator
|
See JeniT/linked-csv#2. I think this should be done through a deeper change. The specification for Linked CSV should be changed to sniff that the type of a value is a URL. Then the code for parsing the Linked CSV should be changed to perform that sniffing and to type the value as a URL. The existing code will then display the link. |
Added support for sniffing values as URIs, whenever the type is not set explicitly to 'url', but the value is an URI. Also, I rolled back the previous changes to browser.js which displayed URI strings as anchors. This is now done by the rest of the code, once the string is identified to be an URI.
Added an alternative representation of URIs, as full URI strings part of an anchor tag. The icon representation remains a default, but using a query string parameter (showUri=true), the URIs can be displayed in a readable manner.
Added an alternative representation of URIs, as full URI strings part of an anchor tag. The icon representation remains a default, but using a query string parameter (showUri=true), the URIs can be displayed in a readable manner.
This reverts commit 2f92d74.
This reverts commit a27b1f3.
Added an alternative representation of URIs, as full URI strings part of an anchor tag. The icon representation remains a default, but using a query string parameter (showUri=true), the URIs can be displayed in a readable manner.
Correcting the way the query string parameter is used and detected. Using '&' instead of '?', since it cannot be the first query string parameter.
Correcting the way the query string parameter 'uri=' is being transferred as a Load URL for CSV files / content. The addition of the 'showUri' query string parameter makes this change necessary. The original code does not assume usage of other query string parameters besides the 'uri' parameter.
Changed the default URI display from icons to HTML anchors. If a user wants to view the URIs as icons, the optional query string parameter 'showUri' can be used, with the value set to 'false', i.e. "&showUri=false".
Changed the default URI display from icons to HTML anchors. If a user wants to view the URIs as icons, the optional query string parameter 'showUri' can be used, with the value set to 'false', i.e. "&showUri=false".
Conflict resolution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added support for displaying values which represent an URI as links
(anchors) in the HTML table. This way, the values which represent an URI can be browsed directly from the results of the tool, just as users are supposed to in a Linked Data / Semantic Web scenario.
For instance, if we browse this example, the values in the cells are currently displayed as text. The goal is to display them as they are here, so that the user can continue browsing data from other places on the web.
It's a small change, but we believe it may be important.