Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ackoff Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- DingTalk: pass retryCtx (not outer ctx) into doEmojiRequest so the 30s outer budget actually bounds per-attempt HTTP calls - Feishu: move reactionCh send/close outside the retry lambda to eliminate channel side-effects in a retried function - RetryWithBackoff: replace time.After with time.NewTimer+Stop to reclaim timer memory immediately on context cancellation - Remove what-not-why comments on addThinkingEmoji/recallThinkingEmoji Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove redundant multi-line comment from RetryWithBackoff - Use range-over-int loop form - Extract magic retry count/delay values as named constants in dingtalk and feishu handlers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Export DefaultRetryCount/DefaultRetryDelay from internal/utils to eliminate duplicate constants in dingtalk and feishu handlers - Refactor doEmojiRequest to accept pre-fetched token and payload so auth and payload-build are not repeated on every retry attempt - Extract doEmojiRequestWithRetry helper to remove copy-paste between addThinkingEmoji and recallThinkingEmoji - Add 30s bounded context to Feishu add-reaction retry (was using unbounded handler ctx) - Hoist recallCtx/cancel before the select in Feishu recall goroutine so defer fires unconditionally regardless of which select branch runs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.