feat(Card): Update Card styled component for manage more styles#6
Merged
phurytw merged 1 commit intotheopenconversationkit:masterfrom Feb 20, 2020
Merged
Conversation
phurytw
suggested changes
Feb 17, 2020
| @@ -0,0 +1,11 @@ | |||
| export interface TockThemeCardStyle { | |||
| card?: string; | |||
Contributor
There was a problem hiding this comment.
I think container should be a better name to avoid theme.style.card.card.
Comment on lines
+7
to
+8
| ulButton?: string; | ||
| liButton?: string; |
Contributor
There was a problem hiding this comment.
Have more explicit names such as buttonContainer and/or button
MaximeLefrancois
force-pushed
the
UpdateCard
branch
from
904e1a2 to
b85d1ef
Compare
MaximeLefrancois
force-pushed
the
UpdateCard
branch
from
b85d1ef to
f0826a7
Compare
Collaborator
Author
|
@phurytw : I make the changes. |
phurytw
approved these changes
Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.