Skip to content

feat: add support for fga modules + fix bug with validate id#455

Merged
golanglemonade merged 5 commits intomainfrom
feat-fga-modules
Mar 7, 2026
Merged

feat: add support for fga modules + fix bug with validate id#455
golanglemonade merged 5 commits intomainfrom
feat-fga-modules

Conversation

@golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Mar 7, 2026

  • adds support for fga modules, keeping backwards compatibility with a single model file
  • fixes id check to use regex - some valid strings besides just wildcard are valid in our setup such as openlane_core

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@github-actions github-actions bot added the enhancement New feature or request label Mar 7, 2026
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade marked this pull request as ready for review March 7, 2026 02:50
@golanglemonade golanglemonade requested a review from a team as a code owner March 7, 2026 02:50
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade changed the title feat: add support for fga modules feat: add support for fga modules + fix bug with validate id Mar 7, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
2.9% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade enabled auto-merge (squash) March 7, 2026 05:49
@golanglemonade golanglemonade merged commit aa62ee8 into main Mar 7, 2026
12 of 13 checks passed
@golanglemonade golanglemonade deleted the feat-fga-modules branch March 7, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants