fix: display snaps on first render if zoom within threshold#112
Merged
jessicamcinchak merged 1 commit intomainfrom Feb 4, 2022
Merged
fix: display snaps on first render if zoom within threshold#112jessicamcinchak merged 1 commit intomainfrom
jessicamcinchak merged 1 commit intomainfrom
Conversation
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: 5cc32de 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/61fd19ba3736210008af3e58 😎 Browse the preview: https://deploy-preview-112--oslmap.netlify.app/ |
Member
Author
DafyddLlyr
approved these changes
Feb 4, 2022
Comment on lines
+390
to
+391
| // define zoom threshold for showing snaps (not @property yet because computationally expensive!) | ||
| const snapsZoom: number = 20; |
Contributor
There was a problem hiding this comment.
I agree that making this accessible would be a bad idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosly, we'd only render snaps after a map move (zoom, pan, etc) - this change makes snaps visible on the first render before any interactions if other conditions are met (
drawModeis enabled,zoomis greater than or equal to 20)