feat: address-autocomplete supports a default value#120
Merged
jessicamcinchak merged 1 commit intomainfrom Mar 22, 2022
Merged
Conversation
4 tasks
|
✅ Deploy Preview for oslmap ready! 🔨 Explore the source changes: b19e0fe 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/623a0df78292220008caa920 😎 Browse the preview: https://deploy-preview-120--oslmap.netlify.app/ |
gunar
approved these changes
Mar 22, 2022
| }); | ||
|
|
||
| this._options.sort((a, b) => a.localeCompare(b)); | ||
| const collator = new Intl.Collator([], { numeric: true }); |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ability to set an
initialAddressprop on the web component, which is then passed to accessible-autocomplete'sdefaultValueoption: https://github.com/alphagov/accessible-autocomplete.this will enable us to show the prior selected address when "going back" or "changing" your site address in planx.
in the planx use case, since our
initialAddresswill only ever be one that was selected prior, we can assume that we already have the full address record stored in the passport/state from a prior event dispatch, and don't need to fire a new one on initial render.small bonus of improved options sorting in the dropdown - before address "103..." would show up before "47..." etc.