fix: postcode-search & address-autocomplete should set tabindex="0"#122
Merged
jessicamcinchak merged 1 commit intomainfrom Mar 23, 2022
Merged
fix: postcode-search & address-autocomplete should set tabindex="0"#122jessicamcinchak merged 1 commit intomainfrom
jessicamcinchak merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jessicamcinchak
commented
Mar 23, 2022
| if (data.error || data.fault) { | ||
| this._osError = | ||
| data.error?.message || | ||
| data.fault?.faultstring || |
Member
Author
There was a problem hiding this comment.
One common example of when OS returns a faultstring is if there's an invalid API key, like this:
<address-autocomplete postcode="SE5 0HU" osPlacesApiKey="fake" />
jessicamcinchak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
am experiencing some unexpected screenreader behavior during planx integration, hoping
tabindex="0"will smooth it out! we were already settingtabindexon the main map div and that component is read out as expected by my screenreader, so I'm fairly hopeful here.this 2014(!) blog reassures that elements rendered in the shadow DOM (as these web components are when integrated into our React frontend) should simply be part of "one happy tree" as far as screenreaders are concerned 🌳
a few other minor fixes here too: