feat: Improve style of autocomplete#128
Merged
DafyddLlyr merged 2 commits intomainfrom Mar 24, 2022
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jessicamcinchak
approved these changes
Mar 24, 2022
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
visually subtle, but so much more usable - thanks!!
| osPlacesApiKey = import.meta.env.VITE_APP_OS_PLACES_API_KEY || ""; | ||
|
|
||
| @property({ type: String }) | ||
| arrowStyle = "default"; |
Member
There was a problem hiding this comment.
i've been defining typescript types in lieu of Lit offering an enum property type, that might make sense here too? usually just leads to clearer error messages if debugging, nicer vscode prefill suggestions, etc
here's an example from the map properties:
type DrawPointerEnum = "crosshair" | "dot";
@property({ type: String })
drawPointer: DrawPointerEnum = "crosshair";
|
|
||
| getLightDropdownArrow() { | ||
| return '<svg class="autocomplete__dropdown-arrow-down" style="height: 17px;" viewBox="0 0 512 512" ><path d="M256,298.3L256,298.3L256,298.3l174.2-167.2c4.3-4.2,11.4-4.1,15.8,0.2l30.6,29.9c4.4,4.3,4.5,11.3,0.2,15.5L264.1,380.9 c-2.2,2.2-5.2,3.2-8.1,3c-3,0.1-5.9-0.9-8.1-3L35.2,176.7c-4.3-4.2-4.2-11.2,0.2-15.5L66,131.3c4.4-4.3,11.5-4.4,15.8-0.2L256,298.3 z"/></svg>'; | ||
| } |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few little fixes and improvements.
:focus-visiblering, see issue here - Focus should be unstyled on menu items alphagov/accessible-autocomplete#73