Skip to content

fix: Further a11y fixes for autocomplete#131

Merged
DafyddLlyr merged 2 commits intomainfrom
dp/autocomplete-a11y-fixes
Mar 28, 2022
Merged

fix: Further a11y fixes for autocomplete#131
DafyddLlyr merged 2 commits intomainfrom
dp/autocomplete-a11y-fixes

Conversation

@DafyddLlyr
Copy link
Copy Markdown
Contributor

See following message (28/03/22) -

“We have noticed that the label for the autocomplete is not marked up correctly and comes across as unlabelled, this is due to the htmlfor and should just be ‘for’

<label class="govuk-label" htmlfor="address-autocomplete"><!--?lit$21620639537$-->Select an address</label>

<label class="govuk-label" for="address-autocomplete"><!--?lit$21620639537$-->Select an address</label>

As for functionality for the autocomplete this is much better but there is a slight issue where the status has been applied to an outside div which is resulting in the options all reading out in one go. This needs to be removed.

#address-autocomplete-container

<div role="status" spellcheck="false" id="address-autocomplete-container"><div class="autocomplete__wrapper">

Please let me know when these are resolved and I can update the report and send over.”

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 28, 2022

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit c1c4ff4
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/6241d7e799f6c30008282e77
😎 Deploy Preview https://deploy-preview-131--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

htllFor is just a React thing 🤦 won't forget that again!

@DafyddLlyr DafyddLlyr merged commit d842504 into main Mar 28, 2022
@DafyddLlyr DafyddLlyr deleted the dp/autocomplete-a11y-fixes branch March 28, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants