fix: Ensure error container is always in DOM (autocomplete)#136
Merged
DafyddLlyr merged 3 commits intomainfrom Mar 29, 2022
Merged
fix: Ensure error container is always in DOM (autocomplete)#136DafyddLlyr merged 3 commits intomainfrom
DafyddLlyr merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jessicamcinchak
approved these changes
Mar 29, 2022
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
nice solution, each render role="status" as expected for me!
| * Render an errorMessage container | ||
| * Must always be visible to ensure that role="status" works for screenreaders | ||
| * @param errorMessage | ||
| * @returns TemplateResult |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.