feat: add resetControlImage prop for testing custom icons#209
Merged
jessicamcinchak merged 1 commit intomainfrom Oct 17, 2022
Merged
feat: add resetControlImage prop for testing custom icons#209jessicamcinchak merged 1 commit intomainfrom
resetControlImage prop for testing custom icons#209jessicamcinchak merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
DafyddLlyr
approved these changes
Oct 14, 2022
Contributor
DafyddLlyr
left a comment
DafyddLlyr
left a comment
There was a problem hiding this comment.
Looks good!
Agree it's a tricky / slow one to test. I think a single icon library is probably best from realistically to try to maintain a standard look and feel.
Let's see what the feedback is!
This was referenced Oct 17, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
resetControlImageENUM property to specify a custom icon to show on the reset control button. Defaults to our current unicode arrow.This is a bit of a tricky UAT request because we need to make a whole release. Once an icon is decided on, an ENUM property will likely be unnecessary and we can clean this up. If we decide to go with one of these new options, it may also be worth considering to source all icons from Carbon rather than mixing libraries?
resetControlImagevalueunicode(default)resettrasherase