feat: enable drawing single point#232
Merged
jessicamcinchak merged 1 commit intomainfrom Dec 9, 2022
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
DafyddLlyr
approved these changes
Dec 9, 2022
Contributor
DafyddLlyr
left a comment
DafyddLlyr
left a comment
There was a problem hiding this comment.
This is great, always good to see a simple PR that offers a solid bit of extra functionality 👏
| import { StyleLike } from "ol/style/Style"; | ||
| import { pointsSource } from "./snapping"; | ||
|
|
||
| export type DrawTypeEnum = "Polygon" | "Point"; // ref https://openlayers.org/en/latest/apidoc/module-ol_geom_Geometry.html#~Type |
| }); | ||
|
|
||
| export const drawingSource = new VectorSource(); | ||
| const boundaryLayerStyle: StyleLike = [ |
Contributor
There was a problem hiding this comment.
I think there might be future scope for extracting these out into a style.ts or similar 👍
Member
Author
There was a problem hiding this comment.
Yep totally fair, definitely getting a bit cluttered as-is !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
drawModepreviously assumed the geometry type "Polygon" because we've only used it for drawing site boundariesChanges:
drawTypeto specify "Polygon" (default) or "Point" when usingdrawModedrawPointColorto specify the color of the featureareaChangeevent when drawing a "Polygon"geojsonChangeeventTo test:
Future scope: