Skip to content

chore: remove unused reset icons, swap new north arrow#233

Merged
jessicamcinchak merged 1 commit intomainfrom
jess/cleanup-icons
Dec 9, 2022
Merged

chore: remove unused reset icons, swap new north arrow#233
jessicamcinchak merged 1 commit intomainfrom
jess/cleanup-icons

Conversation

@jessicamcinchak
Copy link
Copy Markdown
Member

  • Swaps out north arrow icon for new one provided by Alastair
  • Limits reset control image options to two for simplicity based on recent user feedback

Screenshot from 2022-12-08 17-23-58

To test:

<my-map drawMode showScale showNorthArrow resetControlImage="trash" />

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 8, 2022

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit bf2c5e8
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/639210f005009000083ff6ae
😎 Deploy Preview https://deploy-preview-233--oslmap.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jessicamcinchak
Copy link
Copy Markdown
Member Author

@jessicamcinchak jessicamcinchak requested a review from a team December 8, 2022 16:30
Copy link
Copy Markdown
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Pitsby - looks great 👌

@jessicamcinchak jessicamcinchak merged commit 9b5a00d into main Dec 9, 2022
@jessicamcinchak jessicamcinchak deleted the jess/cleanup-icons branch December 9, 2022 08:06
jessicamcinchak added a commit that referenced this pull request Dec 9, 2022
* build(deps-dev): bump happy-dom from 7.8.1 to 8.1.0

Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 7.8.1 to 8.1.0.
- [Release notes](https://github.com/capricorn86/happy-dom/releases)
- [Commits](capricorn86/happy-dom@v7.8.1...v8.1.0)

---
updated-dependencies:
- dependency-name: happy-dom
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: remove unused reset icons, swap new north arrow (#233)

* build(deps-dev): bump vitest from 0.25.5 to 0.25.6 (#235)

* build(deps-dev): bump vitest from 0.25.5 to 0.25.6

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 0.25.5 to 0.25.6.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v0.25.6/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* add lock file

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jessica McInchak <jessica.mcinchak@gmail.com>

* build(deps-dev): bump vite from 3.2.5 to 4.0.0 (#234)

* build(deps-dev): bump vite from 3.2.5 to 4.0.0

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.5 to 4.0.0.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.0.0/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* add lock file

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jessica McInchak <jessica.mcinchak@gmail.com>

* add lock file

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jessica McInchak <jessica.mcinchak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants