feat: query & display features that intersect with lon,lat#24
Merged
jessicamcinchak merged 4 commits intomainfrom Aug 10, 2021
Merged
feat: query & display features that intersect with lon,lat#24jessicamcinchak merged 4 commits intomainfrom
jessicamcinchak merged 4 commits intomainfrom
Conversation
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: 1497391 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/61126ed7b91d5b0007daa7fb 😎 Browse the preview: https://deploy-preview-24--oslmap.netlify.app |
jessicamcinchak
commented
Aug 10, 2021
|
|
||
| @property({ type: Boolean }) | ||
| drawMode = true; | ||
| drawMode = false; |
Member
Author
There was a problem hiding this comment.
this is a slightly extraneous, but key change! made the decision here that our various feature modes should each be "off" by default. once this is merged & published, we should update the codesandbox demo to explicitly turn on 'drawMode'.
Contributor
There was a problem hiding this comment.
Yeah that makes sense!
If this gets published we'll need to notify bops of this change too, or get them to work with a previous fixed version number for now until the API is a bit more settled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creeping into the "future" features with this one, but the logic was basically already on hand from our first implementation! this will let us show a border around the address point in FindProperty component & move towards having a more accurate polygon/geojson to make more accurate planning constraint queries in the future.
example implementation: