fix: Display scalebar correctly#252
Merged
DafyddLlyr merged 1 commit intomainfrom Jan 10, 2023
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
DafyddLlyr
commented
Jan 10, 2023
| pointsSource, | ||
| } from "./snapping"; | ||
| import styles from "./styles.scss"; | ||
| import styles from "./styles.scss?inline"; |
Contributor
Author
There was a problem hiding this comment.
Without this I was getting the following error when running the app -
DafyddLlyr
commented
Jan 10, 2023
Comment on lines
+46
to
+48
| .ol-scale-bar-inner { | ||
| display: flex; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this isn't being applied correctly by default - maybe an issue with the OL CSS? Is it possible that Vite is doing some building/packaging and not importing an unused class?
jessicamcinchak
approved these changes
Jan 10, 2023
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227
Picked this up whilst looking at https://trello.com/c/jVS79IdF/2230-can-automatically-generated-location-plan-click-to-standard-scales