feat: dispatch geojsonChange events in two projections#255
Merged
jessicamcinchak merged 2 commits intomainfrom Jan 20, 2023
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jessicamcinchak
commented
Jan 19, 2023
DafyddLlyr
approved these changes
Jan 20, 2023
jessicamcinchak
deleted the
jess/dispatch-geojson-change-events-in-two-projections
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing or selecting features, dispatch their associated geojson change events in two projections: EPSG:3857 (web mercator) & EPSG:27700 (BNG). Previously, we defaulted to only EPSG:3857.
In PlanX, this will enable us to easily get both the Easting (X), Northing (Y) & longitude, latitude coordinates of a point or polygon without needing to install any extra dependencies to handle further conversions later.
Will flag as a break in our next release, as it changes the data format output by the event!