Allow drawing colour and fill to be customisable#379
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jessicamcinchak
left a comment
There was a problem hiding this comment.
Thanks for these changes, a very useful feature! Two minor comments, but otherwise looks great 🖍️
| name: "drawingFillColor", | ||
| type: "String", | ||
| values: "", | ||
| }, |
There was a problem hiding this comment.
Thanks for updating docs too ✨ I'd expect these new props to be added to docs/my-map-draw.doc.js rather than -features though please
There was a problem hiding this comment.
Oh yeah woopsie
| width: 3, | ||
| }), | ||
| }), | ||
| polygonVertices, |
There was a problem hiding this comment.
nit: can polygonVertices also be refactored as a small function that takes the drawingColor argument ? They're still hardcoded to red!
1282ac6 to
32ce781
Compare
jessicamcinchak
left a comment
There was a problem hiding this comment.
Sorry two more minor tweaks that I just caught on final review!
Once adjusted, I'm happy to approve and merge this and make the release (limited permissions to that step because OSL NPM account) and share new version number with you for use 🎉 Thanks again for this!
9da0142 to
c027c39
Compare
c027c39 to
132bfd2
Compare
Description of change
Trello ticket:
https://trello.com/c/IQsb3WNF/1908-improve-content-and-layout-for-querying-neighbour-addresses-by-polygon-search