feat: ability to set multiple custom attributions and collapse#424
Merged
jessicamcinchak merged 1 commit intomainfrom Jan 2, 2024
Merged
feat: ability to set multiple custom attributions and collapse#424jessicamcinchak merged 1 commit intomainfrom
jessicamcinchak merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
jessicamcinchak
changed the title
DafyddLlyr
approved these changes
Jan 2, 2024
Contributor
DafyddLlyr
left a comment
DafyddLlyr
left a comment
There was a problem hiding this comment.
Perfect! Nice and simple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the map supported a single prop
osCopyrightto specify the basemap attibution. This was un-collapsed by default and not configurable.Now, we'll support multiple copyright props and expose the collapse prop to the user. Multiple copyrights are styled to be stacked on top of each other, rather than single-line.
Before / still default state:
Now / maximum three distinct attributions:
Now / collapsed attributions:
