fix: update featuresGeojsonChange event to match new geojsonChange behavior#479
Merged
jessicamcinchak merged 2 commits intomainfrom Aug 26, 2024
Merged
Conversation
✅ Deploy Preview for oslmap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DafyddLlyr
approved these changes
Aug 26, 2024
Comment on lines
+556
to
+560
| sketch.set( | ||
| "area.squareMetres", | ||
| calculateArea(sketchGeom, "m2"), | ||
| ); | ||
| sketch.set("area.hectares", calculateArea(sketchGeom, "ha")); |
Contributor
There was a problem hiding this comment.
fyi: There's a setProperties() that allows multiple values to be set at once. No better or worse, just sharing!
Comment on lines
+30
to
+34
| switch (unit) { | ||
| case "m2": | ||
| return squareMetres; | ||
| case "ha": | ||
| return hectares; |
Co-authored-by: Dafydd Llŷr Pearson <DafyddLlyr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #466
Changes:
drawMode- theclickFeaturesfunctionality dispatches geojson & area events which should stay consistent with recent changes we've made to event dispatching - so we're deprecatingfeaturesAreaChangeevent and instead setting"area"directly on thefeaturesGeojsonChangeevent data "properties"areaUnitprop and simply sets both"area.squareMetres"and"area.hectares"anywhere we calculate the area (these field names & new number type are more consistent with ODP Schema too)