Skip to content

feat: show vertices of drawn polygon#57

Merged
jessicamcinchak merged 2 commits intomainfrom
jess/drawing-styles
Sep 21, 2021
Merged

feat: show vertices of drawn polygon#57
jessicamcinchak merged 2 commits intomainfrom
jess/drawing-styles

Conversation

@jessicamcinchak
Copy link
Copy Markdown
Member

@jessicamcinchak jessicamcinchak commented Sep 12, 2021 •
edited
Loading

  • Show vertices of drawn polygon once a shape has been closed; user can modify existing vertices or add new ones (design similar to MapInfo Professional used internally at Buckinghamshire)
  • Tweak default drawing style to have more prominent fill color
  • Increase snap pixel tolerance against drawing layer so it's a bit easier to close your drawing & grab an existing vertex to modify

Screenshot from 2021-09-12 13-54-08

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 12, 2021 •
edited
Loading

✔️ Deploy Preview for oslmap ready!

🔨 Explore the source changes: b56c175

🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/6149b076f390c100072fe285

😎 Browse the preview: https://deploy-preview-57--oslmap.netlify.app

@jessicamcinchak jessicamcinchak marked this pull request as draft September 17, 2021 11:34
@jessicamcinchak
Copy link
Copy Markdown
Member Author

jessicamcinchak commented Sep 21, 2021

Snap to OS base map layer?

@jessicamcinchak jessicamcinchak marked this pull request as ready for review September 21, 2021 10:31
@jessicamcinchak jessicamcinchak requested a review from a team September 21, 2021 10:31
melzreal
melzreal approved these changes Sep 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@melzreal melzreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jessicamcinchak jessicamcinchak merged commit d929a53 into main Sep 21, 2021
@jessicamcinchak jessicamcinchak deleted the jess/drawing-styles branch September 21, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@melzreal melzreal melzreal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessicamcinchak @melzreal