tidy up snaps#74
Merged
jessicamcinchak merged 11 commits intojr/snappingfrom Nov 10, 2021
Merged
Conversation
Member
Author
|
going to merge into your PR so we have a single place for BOPs devs to code review & can unblock this ! https://trello.com/c/rQMerGkO/447-red-line-tool-snap-to-feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like more than it is because i'm based off main!
makes sure we only add the snapping layer when in drawMode with the vectorTile basemap enabled
shuffles the code around a bit to keep it closer to drawing logic in the flow of my-map.ts, and moves a couple more definitions to snapping.ts
not thinking about styling yet! maybe just easiest to set a snapping color property so it's easy to keep changing minds about? 🙃
also still thinking about how snaps should work once you close your shape? can we actually modify-to-snaps? if we cant, maybe points should disappear?