feat: snap to vector tile basemap features#75
Merged
jessicamcinchak merged 16 commits intomainfrom Nov 12, 2021
Merged
Conversation
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: 577ac9a 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/618cff4e45bcbf0008281014 😎 Browse the preview: https://deploy-preview-75--oslmap.netlify.app |
jessicamcinchak
changed the title
Closed
Member
Author
gunar
approved these changes
Nov 10, 2021
| } | ||
|
|
||
| // extract snap-able points from the basemap, and display them as points on the map | ||
| setTimeout(() => { |
Contributor
There was a problem hiding this comment.
Is this timeout really necessay?
Member
Author
There was a problem hiding this comment.
the timeout helps keep the zoom & pan interactions feeling a lot smoother in my opinion, and a bit more performant to only extract the snap points once a user has settled on location rather than mid-drag
| "experimentalDecorators": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "lib": ["es2017", "dom", "dom.iterable"], | ||
| "lib": ["es2019", "dom", "dom.iterable"], |
Contributor
There was a problem hiding this comment.
Can we keep es2017 just in case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation assumptions:
drawModeis enabled and zoom level > 20Default styles:
Closes #55