fix: keep snapping behaviour while modifying polygon#83
Merged
Conversation
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: 6180751 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/6197923519dfe60008d124a8 😎 Browse the preview: https://deploy-preview-83--oslmap.netlify.app |
| map.addInteraction(modify); | ||
|
|
||
| // XXX: snap must be added after draw and modify | ||
| map.addInteraction(snap); |
Member
There was a problem hiding this comment.
oo this is interesting!! i had tried not removing the snap interaction, but hadn't thought to re-order how they're added! and figured because the modify interaction can only have a single source which is drawingSource, rather than the pointsSource, that it wasn't quite possible
jessicamcinchak
approved these changes
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should fix this issue with modify shape not snapping, apologies for the extra prettier noise! We'll get prettier running on everything in this repo again at some point.
Steps taken