fix: A11y improvements#95
Merged
DafyddLlyr merged 2 commits intomainfrom Dec 14, 2021
Merged
Conversation
Ensure zoom and reset buttons are 44px x 44px Apply aria-label attribute to controls
|
✔️ Deploy Preview for oslmap ready! 🔨 Explore the source changes: ca3e02d 🔍 Inspect the deploy log: https://app.netlify.com/sites/oslmap/deploys/61b70cd9542cb70008a3bac5 😎 Browse the preview: https://deploy-preview-95--oslmap.netlify.app |
|
|
||
| // Apply aria-labels to OL Controls for accessibility | ||
| const olControls: NodeListOf<HTMLButtonElement> | undefined = | ||
| this.shadowRoot?.querySelectorAll(".ol-control button"); |
Member
There was a problem hiding this comment.
Lit nit: I think within firstUpdated(), it's more standard/comprehensive to use renderRoot rather than shadowRoot - the renderRoot will be the shadowRoot or an element, and still has access to the .querySelectorAll() method.
Docs here for reference https://lit.dev/docs/components/shadow-dom/#accessing-nodes-in-the-shadow-dom
jessicamcinchak
approved these changes
Dec 10, 2021
Member
jessicamcinchak
left a comment
jessicamcinchak
left a comment
There was a problem hiding this comment.
thanks for these improvements!! two minor comments, but happy for this to merge whenever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues raised in the following two tickets -
Fixes
pointer: cursorto buttonsaria-labelattribute to controls