Skip to content

Conversation

@iCrazeiOS
Copy link
Contributor

What does this implement/fix? Explain your changes.

Changes HBLogDebug behaviour to match its pre-iOS10 implementation.

Any other comments?

This change was discussed in #developers from the Chariz discord server.

Where has this been tested?

Operating System: macOS Monterey

@leptos-null
Copy link
Member

Linking the discussion mentioned for reference: https://discord.com/channels/326739046531596289/326747945724674048/1259922156687593593

Adding a snippet from Kirb in that thread:

I think that [HBDebugLog logging in non-debug builds] was intentional, because the performance of making debug logs with os_log is negligible
whether it matches what users expect, for those strings to not be compiled in, maybe not, though

Building on that, Apple includes debug logs in release builds, including for systems that are not relevant for developing user applications.

Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I personally believe it is best practice to include debug logs (using the os_log system) in non-debug builds, Kirb's point that code may be compiled into a distributed build that would not have otherwise been due to using a different SDK version or minimum deployment version seems confusing.

In the referenced Discord discussion, Kirb also showed his support for this change.

@L1ghtmann L1ghtmann merged commit 8194da1 into theos:master Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants