release: 0.17.2-alpha.2 — inline reflectapi-schema-codegen#135
Merged
Conversation
…dule + 0.17.2-alpha.2 The reflectapi-schema-codegen crate had exactly one consumer (reflectapi/src/codegen/python.rs) and wasn't re-exported through reflectapi's public API. Publishing it would commit us to a semver contract on the still-evolving semantic IR (#129), and the first release hit the crates.io Trusted Publishing limitation that new crates can't be created via OIDC. Move ids/normalize/semantic/symbol back into the reflectapi crate as reflectapi::codegen::schema (pub(crate) only). The architectural separation that PR #128 established is preserved at the module boundary; SymbolId / SchemaIds / SemanticSchema can still grow without touching reflectapi-schema (the wire/interchange crate). Concretely: - New: reflectapi/src/codegen/schema/{mod,ids,normalize,semantic,symbol}.rs - Drop: reflectapi-schema-codegen crate + workspace member - Drop: reflectapi's optional dep on it + the codegen feature reference - python.rs: 'use reflectapi_schema_codegen as schema_codegen' -> 'use crate::codegen::schema as schema_codegen' - Module-level #![allow(dead_code)] inside schema/ — most accessor methods are exercised only by the module's own tests today and stay as the supported IR shape for future backend reuse. - mod.rs re-exports trimmed to what python.rs actually consumes; the rest is reachable via self::ids::*, self::normalize::*, etc. - release.yml drops the schema-codegen publish step and version-check entry; README's release section rewritten to match the workflow (Trusted Publishing, dual SemVer/PEP 440 form, tag-driven). Versions: 0.17.2-alpha.1 -> 0.17.2-alpha.2 (Cargo) / 0.17.2a2 (PEP 440).
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-135.partly.workers.dev Updated automatically from commit ca2e4d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to the failed
v0.17.2-alpha.1run: crates.io Trusted Publishing can't create new crates, only update existing ones.reflectapi-schema-codegenwas brand new and blocked the workflow.After review (option B from chat): the codegen IR has exactly one consumer today (
reflectapi's Python codegen), isn't re-exported fromreflectapi's public API, and #129 is still iterating on its shape. So we drop the standalone crate and move its source intoreflectapi::codegen::schema(pub(crate)-only). Same module separation, no public semver contract, no bootstrap problem.Changes
reflectapi/src/codegen/schema/{mod,ids,normalize,semantic,symbol}.rsreflectapi-schema-codegencrate + workspace member +reflectapi's optional deppython.rsnow importscrate::codegen::schema as schema_codegen(one-line)super::*→super::super::*where they reached the schema-codegen lib root)release.ymldrops the schema-codegen publish step and version-check entryREADME.mdRelease section rewritten to match the actual workflow (Trusted Publishing, dual SemVer / PEP 440 versions, tag-driven)Versions
0.17.2-alpha.2(Cargo) /0.17.2a2(PEP 440).Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --workspace(39 schema-IR tests + 168 reflectapi tests + snapshots)git tag v0.17.2-alpha.2 && git push origin v0.17.2-alpha.2and watch the run