Fix Python namespace package imports#159
Merged
Merged
Conversation
Add regressions for parent namespace references, sanitized class names, and sys root namespaces. Also teach CLI directory output to remove stale generated files using a generated-file manifest while preserving non-generated user files.
|
📖 Documentation Preview: https://reflectapi-docs-preview-pr-159.partly.workers.dev Updated automatically from commit 1cbc381 |
Commit the remaining stale generated files removed by CLI cleanup and add the generated-file manifest expected by the Python codegen smoke test.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c91703e98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Avoid following directory symlinks during legacy generated-file discovery and cover the behavior with a Python output-path regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sysshadowingValidation
from ... import <parent>when a submodule references only top-level parent types #158 generated repro: ruff --select F821 + import/rebuild