Delete values regardless of whether they are truthy#15
Merged
AnthonyFuller merged 3 commits intothepeacockproject:mainfrom Apr 26, 2023
Merged
Delete values regardless of whether they are truthy#15AnthonyFuller merged 3 commits intothepeacockproject:mainfrom
AnthonyFuller merged 3 commits intothepeacockproject:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueandContractIdwere only deleted from the context when they are truthy. This caused some challenge contexts to haveValue: ""in them (see issue 207 in the Peacock repo). This pr fixes this. It also changes the way theValueis passed such that if the context already hasValue: "", it will not overwrite the actualValuethat needs to be passed (same forContractId). Ultimately, this PR fixes Mirror Mirror on the Wall being broken.