Added filter rules to file_management.py#11
Open
GrahamDoskoch wants to merge 1 commit intothepetabyteproject:communicationsfrom
Open
Added filter rules to file_management.py#11GrahamDoskoch wants to merge 1 commit intothepetabyteproject:communicationsfrom
GrahamDoskoch wants to merge 1 commit intothepetabyteproject:communicationsfrom
Conversation
I inadvertently had the positional arguments second, after a keyword argument, instead of first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter rules allow the launcher to transfer only the desired files matching a certain regex. This pull request actually contains two changes in my fork: one to add the filter rules, and one that corrects the order of the arguments; I had put a positional argument after a keyword argument.